chore: replace FormControl with PhoneInput component for phone field - #290
Merged
Conversation
…287) * fix: use PhoneInput on Edit Proposal dialog Swap the plain FormControl (type=tel) phone field in ProposalEditDialog.vue for the shared PhoneInput component so the dial code and number are edited separately and saved in Frappe's canonical {isd}-{number} format. This fixes values being saved without the isd- prefix (which render blank in Desk's Phone field, same class of bug as #244) and prevents casual edits of existing hyphen-formatted values from corrupting the format. Fixes #275 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FZ7AVqnfjnXPQbHQd3RVkK * fix: phone input style --------- Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 40757c1)
harshtandiya
changed the title
harshtandiya
added
the
backport
harshtandiya
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport of #287 to
main.